Re: [libvirt] [PATCH 2/2] virutil: fix MinGW build
On 02/03/2015 06:27 AM, Pavel Hrdina wrote:
Commit b38da584 introduced two new functions to get a page size but
it
won't work on Windows. We should take care of this.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/util/virutil.c | 8 ++++++++
1 file changed, 8 insertions(+)
+#else /* WIN32 */
+long virGetSystemPageSize(void)
+{
+ virReportSystemError(ENOSYS, "%s", _("Not supported on this
platform"));
+ return -1;
+}
+#endif /* WIN32 */
Instead of giving up completely, we should probably copy what qemu uses:
size_t getpagesize(void)
{
SYSTEM_INFO system_info;
GetSystemInfo(&system_info);
return system_info.dwPageSize;
}
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)