Re: [libvirt] [PATCH v2 1/5] qemu: whitelist valid video types

On 08/28/2017 03:56 AM, Pavel Hrdina wrote: > On Sun, Aug 27, 2017 at 11:04:38AM -0400, Cole Robinson wrote: >> Rather than require an explicit blacklist that needs to be extended >> for every new VIDEO_TYPE >> >> Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt; >> --- >> src/qemu/qemu_domain.c | 13 +++++-------- >> 1 file changed, 5 insertions(+), 8 deletions(-) > > NACK, we prefer to listing all possible values for typed switch. It > forces a contributor to look at all places where that switch is used > in order to consider whether that place should be updated or not. > This patch isn't necessary anyways, I can drop it and squash this into patch #2, ACK to that? (if so I'll push after the release)