Re: [libvirt] [PATCH 06.1/10] xenconfig: add support for multiple USB devices syntax

Marek Marczykowski-Górecki wrote: > In Xen>=4.3, libxl supports new syntax for USB devices: > usbdevice=[ "DEVICE", "DEVICE", ... ] > Add support for that in xenconfig driver. When only one device is > defined, keep using old syntax for backward compatibility. > Cool, thanks for doing this! But I have a "small" nit... > Signed-off-by: Marek Marczykowski-Górecki <marmarek(a)invisiblethingslab.com&gt; > --- > src/xenconfig/xen_common.c | 108 +++++++++++++++++++++++++++++++-------------- > xm only supported the usbdevice=DEVICE syntax, but the code in xen_common is used to parse/format both xm and xl config. I think parsing/formating of these devices should be moved to xen-xm and xen-xl.