Re: [libvirt] [PATCH v3 24/24] qemu: hotplug: Add support for VCPU unplug

On Wed, Aug 24, 2016 at 09:35:40AM -0400, Peter Krempa wrote: >This patch removes the old vcpu unplug code completely and replaces it >with the new code using device_del. The old hotplug code basically never >worked with any recent qemu and thus is useless. > >As the new code is using device_del all the implications of using it >are present. Contrary to the device deletion code, the vcpu deletion >code fails if the unplug request is not executed in time. >--- > src/qemu/qemu_driver.c | 74 ++++++--------------------------- > src/qemu/qemu_hotplug.c | 108 ++++++++++++++++++++++++++++++++++++++++++++++++ > src/qemu/qemu_hotplug.h | 7 ++++ > 3 files changed, 128 insertions(+), 61 deletions(-) > ACK