RE: [libvirt][PATCH v9 2/5] Transfer Qemu SGX Capabilities to XML

-----Original Message----- From: Michal Prívozník <mprivozn(a)redhat.com&gt; Sent: Friday, January 7, 2022 11:06 PM To: Huang, Haibin <haibin.huang(a)intel.com>; libvir-list(a)redhat.com; Ding, Jian-feng <jian-feng.ding(a)intel.com>; Yang, Lin A <lin.a.yang(a)intel.com>; Lu, Lianhao <lianhao.lu(a)intel.com>; Zhong, Yang <yang.zhong(a)intel.com&gt; Subject: Re: [libvirt][PATCH v9 2/5] Transfer Qemu SGX Capabilities to XML On 12/15/21 04:40, Haibin Huang wrote: > Convert qemu sgx capabilities: > {"sgx": true, "section-size": 0, "flc": false} > > to XML format: > <sgx supported='yes'> > <flc>no</flc> > <epc_size unit='KiB'>1</epc_size> > </sgx> > This should make it obvious which XML you are talking about. It is domain capabilities XML, or domcaps XML for short. For commit message either is usable. > Signed-off-by: Haibin Huang <haibin.huang(a)intel.com&gt; > --- > 99 files changed, 146 insertions(+), 1 deletion(-) > As I said in previous patch, parts of the patch should be moved into this one, because domcaps is semantically different change than QEMU querying. Also, please don't forget to update documentation: docs/formatdomaincaps.html.in You want probably reference new memory model there, so this patch could be moved towards the end, after the new memory model was introduced and documented. Michal