Re: [libvirt] [PATCHv2 2/3] conf: Add new 'append' attribute for chardevs with file source

Currently, there is no possibility for user to specify desired behaviour of output to file - truncate or append. This patch adds an ability to explicitly specify that user wants to preserve file's content on reopen. Signed-off-by: Dmitry Mishin <dim(a)virtuozzo.com&gt; --- docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 28 ++++++++++++++++++++++++---- src/conf/domain_conf.h | 1 + 3 files changed, 30 insertions(+), 4 deletions(-)

@@ -20051,11 +20065,17 @@ virDomainChrSourceDefFormat(virBufferPtr buf, case VIR_DOMAIN_CHR_TYPE_DEV: case VIR_DOMAIN_CHR_TYPE_FILE: case VIR_DOMAIN_CHR_TYPE_PIPE: + /* 'append' makes sense only for files */ + if (def->type != VIR_DOMAIN_CHR_TYPE_FILE) + def->data.file.append = 0;

if (def->type != VIR_DOMAIN_CHR_TYPE_PTY || (def->data.file.path && !(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE))) { virBufferEscapeString(buf, "<source path='%s'", def->data.file.path);

+ if (def->data.file.append)

+ virBufferAsprintf(buf, " append='%s'", + virTristateSwitchTypeToString(def->data.file.append)); virDomainSourceDefFormatSeclabel(buf, nseclabels, seclabels, flags); } break;