Re: [libvirt] [libvirt-java] [PATCH] Set Java source level in pom

On 03/25/2014 10:19 PM, Eric Blake wrote: > On 03/25/2014 09:29 PM, Chris Ellis wrote: >> Hi >> >> Simple patch to set the Java source level within the pom, this makes it >> easier to import the project into Eclipse. I've also added an ignore for >> a local pom file. >> >> I've added plugins to publish the sources and javadocs into Maven. This >> allows Maven (and IDE integration) to automatically use the javadocs and >> source. This should make life easier for users of libvirt-java. >> >> Regards, >> Chris >> >> Chris Ellis (1): >> Update pom to include Java source level >> >> .gitignore | 1 + >> pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 42 insertions(+) >> > > There was no patch accompanying this diffstat. See what the archives > saw: https://www.redhat.com/archives/libvir-list/2014-March/msg01591.html > > You might want to try sending again :) Ah, I see it now: https://www.redhat.com/archives/libvir-list/2014-March/msg01593.html Usually git numbers a cover letter as 0/N to make it obvious it is a cover; also, a cover letter isn't necessary when sending a single patch. At any rate, I'll leave the actual patch review up to someone more familiar with Maven.