Re: [libvirt] [PATCH 1/2] Treat zero cpu shares as a valid value
On 03/04/2014 03:30 PM, Martin Kletzander wrote:
On Tue, Mar 04, 2014 at 02:13:14PM +0100, Ján Tomko wrote:
> Currently, <cputune><shares>0</shares></cputune> is treated
> as if it were not specified.
>
s/were/was/ in this particular case, I guess.
I think this particular case is a perfectly cromulent use of the past
subjunctive to express a counterfactual condition.
ACK,
Martin
Thank you for the review, I will take another look at the series before
pushing, since this was an RFC.
Jan
Attachments:
- signature.asc (application/pgp-signature — 836 bytes)