Re: [libvirt] [PATCH 8/9] virsh: Introduce virshDomainBlockTargetCompleter
On 05/15/2018 01:18 PM, Lin Ma wrote:
Signed-off-by: Lin Ma <lma(a)suse.com>
---
tools/virsh-completer.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
tools/virsh-completer.h | 4 ++++
2 files changed, 52 insertions(+)
diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c
index e3b8234b41..11fe44055d 100644
--- a/tools/virsh-completer.c
+++ b/tools/virsh-completer.c
@@ -143,6 +143,54 @@ virshDomainInterfaceCompleter(vshControl *ctl,
}
+char **
+virshDomainBlockTargetCompleter(vshControl *ctl,
I think virshDomainDiskTargetCompleter is better name. "Block" suggests
it's only working with block devices. Although I know you just took the
inspiration in our (dom-)blk* commands.
Michal