Re: [libvirt] [PATCH 0/2] Don't colorize output senselessly
On Wed, Sep 18, 2019 at 16:18:23 +0200, Michal Privoznik wrote:
On 9/18/19 9:58 AM, Peter Krempa wrote:
> Basing the colors on the message itself is in many cases wrong. Look
> into the patches for examples.
>
> Peter Krempa (2):
> Revert "virt-result.m4: Colourize summary printings"
> Revert "configure: Colorize output"
>
> m4/virt-colours.m4 | 62 ----------------------------------------------
> m4/virt-result.m4 | 21 +++-------------
> 2 files changed, 3 insertions(+), 80 deletions(-)
> delete mode 100644 m4/virt-colours.m4
>
Looks like this made people more angry than I anticipated. Feel free to
revert the patches.
I want to emphasise that I don't have problem with using colored text to
simplify spotting problems. One example is the colored output of our
unit test suite where the usage of colors allows me to find a broken
test quickly.
ACK
Michal
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)