Re: [libvirt] [RFC][PATCH 4/7] interface: implement the remote protocol

--- src/remote/remote_driver.c | 6 +++--- src/remote/remote_protocol.x | 18 +++++++++++++++++- src/remote_protocol-structs | 9 +++++++++ 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index d56f352..a974b39 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -6534,9 +6534,9 @@ static virInterfaceDriver interface_driver = { .interfaceCreate = remoteInterfaceCreate, .interfaceDestroy = remoteInterfaceDestroy, .interfaceIsActive = remoteInterfaceIsActive, - .interfaceChangeStart = NULL, - .interfaceChangeCommit = NULL, - .interfaceChangeRollback = NULL, + .interfaceChangeStart = remoteInterfaceChangeStart, + .interfaceChangeCommit = remoteInterfaceChangeCommit, + .interfaceChangeRollback = remoteInterfaceChangeRollback, }; static virStorageDriver storage_driver = { diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index c706c36..95f636c 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -1143,6 +1143,18 @@ struct remote_interface_destroy_args { unsigned int flags; }; +struct remote_interface_change_start_args { + unsigned int flags; +}; + +struct remote_interface_change_commit_args { + unsigned int flags; +}; + +struct remote_interface_change_rollback_args { + unsigned int flags; +}; + /* Auth calls: */ @@ -2176,7 +2188,11 @@ enum remote_procedure { REMOTE_PROC_DOMAIN_GET_BLKIO_PARAMETERS = 206, REMOTE_PROC_DOMAIN_MIGRATE_SET_MAX_SPEED = 207, REMOTE_PROC_STORAGE_VOL_UPLOAD = 208, - REMOTE_PROC_STORAGE_VOL_DOWNLOAD = 209 + REMOTE_PROC_STORAGE_VOL_DOWNLOAD = 209, + REMOTE_PROC_INTERFACE_CHANGE_START = 210, + + REMOTE_PROC_INTERFACE_CHANGE_COMMIT = 211, + REMOTE_PROC_INTERFACE_CHANGE_ROLLBACK = 212 /* * Notice how the entries are grouped in sets of 10 ? diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index f904c4d..8f524f0 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -783,6 +783,15 @@ struct remote_interface_destroy_args { remote_nonnull_interface iface; u_int flags; }; +struct remote_interface_change_start_args { + unsigned int flags; +}; +struct remote_interface_change_commit_args { + unsigned int flags; +}; +struct remote_interface_change_rollback_args { + unsigned int flags; +}; struct remote_auth_list_ret { struct { u_int types_len;