Re: [libvirt] [PATCH v3 3/6] travis: convert ubuntu, centos & mingw builds to use new make rules
On Wed, 2019-03-27 at 17:10 +0000, Daniel P. Berrangé wrote:
Change the travis configuration to invoke the new cibuild-$IMAGE
target
instead of directly running docker. This guarantees that when a
developer runs cibuild-$IMAGE locally, the container build setup is
identical to that used in Travis, with exception of the host kernel
and docker version.
It should be "Ubuntu", "CentOS", "MinGW", "Travis
CI" and "Docker"
everywhere in the commit message.
[...]
+ script:
+ - make -f Makefile.ci ci-build@$IMAGE MAKE_ARGS="$MAKE_ARGS"
Two spaces before MAKE_ARGS.
[...]
+ script:
+ - make -f Makefile.ci ci-build@$IMAGE MAKE_ARGS="$MAKE_ARGS"
Same.
[...]
+ script:
+ - make -f Makefile.ci ci-build@$IMAGE CONFIGURE=$MINGW-configure
Please quote the value of CONFIGURE.
[...]
+ script:
+ - make -f Makefile.ci ci-build@$IMAGE CONFIGURE=$MINGW-configure
Same.
With all of the above fixed,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization