Re: [PATCH] qemu: Move some enums impl to qemu_monitor.c
On 2/21/22 17:17, Andrea Bolognani wrote:
On Mon, Feb 21, 2022 at 04:10:25PM +0100, Michal Privoznik wrote:
> +VIR_ENUM_IMPL(qemuMonitorCPUProperty,
> + QEMU_MONITOR_CPU_PROPERTY_LAST,
> + "boolean",
> + "string",
> + "number",
> +);
>
> VIR_ENUM_IMPL(qemuMonitorMigrationStatus,
> QEMU_MONITOR_MIGRATION_STATUS_LAST,
> @@ -4473,6 +4505,14 @@ qemuMonitorTransactionBackup(virJSONValue *actions,
> }
>
>
> +VIR_ENUM_IMPL(qemuMonitorDirtyRateCalcMode,
> + QEMU_MONITOR_DIRTYRATE_CALC_MODE_LAST,
> + "page-sampling",
> + "dirty-bitmap",
> + "dirty-ring",
> +);
> +
> +
Kinda weird that this one ends up in the middle of the file instead
of being grouped with the rest. I'd keep them together, unless
there's a good reason for doing things this way that I missed.
My idea was to keep it close to the rest of dirty rate related
functions. But I can move it next to the rest. I don't have strong
preference.
Either way,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
Thanks, I'll wait for your reply before pushing.
Michal