Re: Re: [PATCH 09/18] qemu: Stop checking QEMU_CAPS_OBJECT_GPEX

On Wed, Jan 17, 2024 at 12:48:39PM +0100, Peter Krempa wrote: > On Wed, Jan 17, 2024 at 10:54:42 +0100, Andrea Bolognani wrote: > > For all versions of QEMU that we support, this is guaranteed to > > be compiled in both on aarch64 and on riscv64, so we can stop > > checking whether the capability is present and just use the > > device unconditionally. > > AFAIK this is not true as there's still a Kconfig option for it and the > corresponding meson files still check for it. Right. Just like the commit message for 8/18, this should be made more accurate. I suggest For all versions of QEMU that we support, the virt machine type has a hard dependency on this device, so we can stop checking whether the capability is present and just use it unconditionally. Sounds good?