[libvirt] [PATCH 5/7] phyp: Resolve Coverity FORWARD_NULL
Commit id 'cd490086' added a VIR_FORCE_CLOSE of the 'sock', but it
was after the VIR_FREE() of phyp_driver, resulting in a possible/likely
NULL dereference.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/phyp/phyp_driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index c558c48..ec0fde3 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -1249,9 +1249,8 @@ phypConnectClose(virConnectPtr conn)
virObjectUnref(phyp_driver->xmlopt);
phypUUIDTable_Free(phyp_driver->uuid_table);
VIR_FREE(phyp_driver->managed_system);
- VIR_FREE(phyp_driver);
-
VIR_FORCE_CLOSE(phyp_driver->sock);
+ VIR_FREE(phyp_driver);
return 0;
}
--
2.1.0