Re: [libvirt PATCH v2 0/5] Add support for vDPA block devices

On Wed, Sep 13, 2023 at 08:56:35AM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote: > > On 9/12/23 7:00 AM, Peter Krempa wrote: > > > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote: > > > > see https://bugzilla.redhat.com/show_bug.cgi?id=1900770. > > > > > > > > Changes in v2: > > > > - Don't use virStorageSource->path for vdpa device path to avoid clashing with > > > > existing path functionality > > > > - Move vdpa device opening to the qemuProcessPrepareHostStorageSource() > > > > function rather than the qemuDomainPrepareStorageSource() function. This > > > > also required some additional support in the tests for setting up the > > > > objects properly for testing. > > > > - rebased to latest master branch > > > > > > Reviewed-by: Peter Krempa <pkrempa(a)redhat.com&gt; > > > > > > > I pushed this series, but for some reason only the ubuntu images are failing > > CI with no useful output: > > https://gitlab.com/libvirt/libvirt/-/pipelines/1001459836 > > This is a behavioural regression from the recent CI refactoring of Eriks'. > > We have lost the "--no-suite syntax-check --print-errorlogs" arguments > when running tests. Sigh. I'm already running a pipeline with a fix that adds those test options back. Erik