Re: [PATCH v3 3/3] qapi: deprecate drive-backup
On Wed, Nov 03, 2021 at 02:29:12PM +0100, Vladimir Sementsov-Ogievskiy wrote:
Modern way is using blockdev-add + blockdev-backup, which provides a
lot more control on how target is opened.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov(a)virtuozzo.com>
Reviewed-by: Kashyap Chamarthy <kchamart(a)redhat.com>
---
docs/about/deprecated.rst | 11 ++++++
docs/interop/live-block-operations.rst | 47 +++++++++++++++++---------
qapi/block-core.json | 5 ++-
3 files changed, 46 insertions(+), 17 deletions(-)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 25b7ec8d92..4a4910143f 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -234,6 +234,17 @@ single ``bitmap``, the new ``block-export-add`` uses a list of
``bitmaps``.
Member ``values`` in return value elements with meta-type ``enum`` is
deprecated. Use ``members`` instead.
+``drive-backup`` (since 6.2)
+''''''''''''''''''''''''''''
Correct here,...
+++ b/docs/interop/live-block-operations.rst
QMP invocation for ``drive-backup``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Note that ``drive-backup`` command is deprecated since QEMU 6.1 and
+will be removed in future.
...but stale here (this patch has been around for a while).
But even though we're in soft freeze, I lean toward this going in
rather than wait yet another release to do the deprecation.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org