Re: [PATCH 0/8] Do more cleaning up after network objects upon start
On 9/3/24 10:36 AM, Martin Kletzander wrote:
This was initially inspired by
https://issues.redhat.com/browse/RHEL-50968 which
does things behind our back. However, I have found some other things when
digging into the aforemention bug.
I rebased, changed, rebased, refactored, and rebased again this branch so many
times there might be a bunch of weird stuff I forgot to remove before posting.
I hope I did not miss any, but one can never be sure ;)
Everything looks fine to me (I've sent Reviewed-by: for most of the
patches). I had responded to one of the patches (that fortunately has
become lost - I don't see it anywhere on the list archives or in my
email client) commenting about going through all the cleanup even for
networks that were already legitimately and completely down, but now
that I've applied all the patches I see that isn't what happens anyway!
(I have no idea what I was thinking)
Anyway
Reviewed-by: Laine Stump <laine(a)redhat.com>
for the entire series, and thanks for fixing a problem that has been
popping up once every year or two for as long as I can remember :-)
Martin Kletzander (8):
network: Do not update network ports for inactive networks
network: Do not call virNetworkObjUnsetDefTransient on start cleanup
network: Move port deletion into the shutdown function
network: Don't check if network is active in networkShutdownNetwork
network: Clean up after inactive objects during start
network: Try to read dnsmasq PIDs for inactive networks too
network: Separate cleanup from networkRemoveInactive
network: Clean up after disappeared transient inactive networks
src/network/bridge_driver.c | 62 ++++++++++++++++++++++++++++++-------
1 file changed, 50 insertions(+), 12 deletions(-)