Re: [libvirt] [PATCH] virsh: fix uninitialized variable in cmdSnapshotEdit
On Fri, Nov 16, 2012 at 12:10:10PM +0100, Ján Tomko wrote:
On 11/16/12 11:58, Christophe Fergeau wrote:
> Shouldn't we call vshError with a different message in the !ret && !name
case?
>
> Christophe
vshCommandOptDomain and vshLookupSnapshot already give reasonable error
messages in that case. For non-existent domains:
error: failed to get domain 'bla'
error: Domain not found: no domain with matching name 'bla'
And for snapshots:
error: Domain snapshot not found: no domain snapshot with matching name
'bla'
Ah, all is good then, thanks!
Christophe
Attachments:
- attachment.sig (application/pgp-signature — 198 bytes)