Re: [libvirt] [PATCH] remove remains of kqemu
On Mon, Feb 18, 2019 at 05:05:01PM +0100, Erik Skultety wrote:
On Mon, Feb 18, 2019 at 04:15:21PM +0100, Ján Tomko wrote:
> We dropped support in commit 8e91a40 (November 2015), but some
> occurrences still remained, even in live code.
>
> Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
> Reported-by: Thomas Huth <thuth(a)redhat.com>
> ---
Can we at least get rid of X_QEMU_CAPS_KQEMU and X_QEMU_CAPS_ENABLE_KQEMU enums
as per: "When a flag is no longer needed we temporarily give it an X_ prefix to
indicate it should no longer be used in code. Periodically we can then purge
all the X_ flags..."
Have we ever actually deleted such flags ? I added that comment
a few years ago, but didn't think we'd ever deleted any flags,
as doing so will prevent us from loading the saved state XML of
any previously running QEMU.
Now, we won't actually support managing such an outdated QEMU
since it is going to lack features that current code assumes
will exist.
In the case of kqemu we can be confident no such running VMs
exist anywhere in the world, but other features it is not so
clearcut.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|