Re: [libvirt] [PATCH 07/10] network: Fix reading 'forwardDelay' attribute.

On Tue, Oct 13, 2009 at 02:27:09PM +0100, Daniel P. Berrange wrote: > On Mon, Oct 12, 2009 at 10:46:51AM -0400, Cole Robinson wrote: >> When reading network XML, we were looking for a 'delay' attribute, but this >> value was being dumped as 'forwardDelay'. Support reading both names on >> input, but continue to only dump 'forwardDelay' > > Rather a no-win situation, but the schema still says 'delay', so I'd > be more inclined to just fix the XML printing code to s/forwardDelay/delay/ > and leave the parsing as is. Agreed, it tends to prove people were either not using the option or not dumping the XML to reimport it. I would stick to the original syntax. This should turn into a trivial fix, and I'm fine with pushing it now. Daniel