On 10/21/2010 12:17 PM, Daniel P. Berrange wrote:
The virSocketParse method was not doing any error reporting
which meant the true cause of the problem was lost. Remove
all error reporting from callers, and push it into virSocketParse
* src/util/network.c: Add error reporting to virSocketParse
* src/conf/domain_conf.c, src/conf/network_conf.c,
src/network/bridge_driver.c: Remove error reporting in
callers of virSocketParse
---
src/conf/domain_conf.c | 6 +-----
src/conf/network_conf.c | 15 +++------------
src/network/bridge_driver.c | 12 ++----------
src/util/network.c | 21 +++++++++++++++++----
4 files changed, 23 insertions(+), 31 deletions(-)
ACK.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org