Re: [libvirt] [PATCH 03/12] qemu: caps: Start probing for egl-headless display type
On Thu, Nov 22, 2018 at 05:36:01PM +0100, Erik Skultety wrote:
QEMU 3.1 introduced the 'query-display-options' QMP command
which in
itself isn't of any use to us since it can only provide information
during runtime as the information is based on what appears on the
cmdline. However, just by having the command in place allows us to
introspect the @DisplayOptions data type in the QAPI schema.
This patch implements the proper way of checking for the 'egl-headless'
display capability. Unfortunately, we can't get rid of the old code
which set the capability based on a specific QEMU (2.10) version just
yet as that would break backwards compatibility.
But we can skip the old code for QEMUs with query-display-options, can't
we?
Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
---
src/qemu/qemu_capabilities.c | 15 ++++++++++-----
Missing test changes.
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)