Re: [libvirt PATCH 0/3] Expose TPM availability in domain capabilities

On Wed, Nov 24, 2021 at 10:11:44AM +0100, Jiri Denemark wrote: > On Wed, Nov 24, 2021 at 10:06:12 +0100, Michal Prívozník wrote: > > On 11/23/21 19:04, Daniel P. Berrangé wrote: > > > If we can report whuether TPM is available, then mgmt apps can enable it > > > by default for new VMs. This is important because OS like Win11 consider > > > TPM to be mandatory. > > > > > > Daniel P. Berrangé (3): > > > conf: add TPM devices to domain capabilities > > > qemu: fill in domain capabilities for TPMs > > > qemu: mock swtpm initialization in tests > > > > > > > > 75 files changed, 661 insertions(+) > > > > > > > Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > > I agree, but I think 3/3 and 2/3 should be swapped because the build > after the current 2/3 depends on host configuration. So chances are the > build might fail for someone at that point. Hmm, it shouldn't depend on host config, because virFindFileInPath is mocked in testutuilsqemu.c which prevents the test suite from ever detecting swtpm. Did you see a particular problem ?