Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

Am 26. März 2024 13:29:58 UTC schrieb "Philippe Mathieu-Daudé" <philmd(a)linaro.org&gt;: Yes, I'd rather keep maintaining the isapc machine and separating it from the i440fx machine seems like a good idea to me. I'm confident that we can work out a way that allows for moving forward the pc-pci machines while keeping the isapc machine from getting into the way too much. Best regards, Bernhard > Also, this machine is particularly >interesting for my single-binary experiments. > >Where I agree is we should stop reporting "KVM on ISA/PC machine" >as supported. > >Regards, > >Phil. > >>> Rather than spending time on fixing 'the oldest' no longer tested machine type, >>> deprecate it so we can clean up QEMU code from legacy fixups and hopefully >>> make it easier to follow. >>> >>> Folks who have to use ancient guest that requires ISAPC can still >>> use older QEMU to play with it. >>> >>> Signed-off-by: Igor Mammedov <imammedo(a)redhat.com&gt; >>> --- >>>   docs/about/deprecated.rst | 7 +++++++ >>>   hw/i386/pc_piix.c         | 1 + >>>   2 files changed, 8 insertions(+) >>> >>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst >>> index 7b548519b5..5708296991 100644 >>> --- a/docs/about/deprecated.rst >>> +++ b/docs/about/deprecated.rst >>> @@ -226,6 +226,13 @@ These old machine types are quite neglected nowadays and thus might have >>>   various pitfalls with regards to live migration. Use a newer machine type >>>   instead. >>> +``isapc`` (since 9.0) >>> +''''''''''''''''''''''''''''''''''''''''''''''''''''' >>> + >>> +These old machine type are quite neglected nowadays and thus might have >> >> "This old machine type is ..." ? >> >>> +various pitfalls with regards to live migration. Use a newer machine type >>> +instead. >> >> I doubt that isapc could ever be used reliably for live migration, since it's an unversioned machine type, so I think it would be better to not mention live migration here. >> >>  Thomas >> >> >