Re: [libvirt] [PATCH 06/16] util: Add virSysfsDirOpen

On Thursday, 30 March 2017 at 10:03 PM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com (mailto:mkletzan@redhat.com)> > --- > src/libvirt_private.syms | 1 + > src/util/virsysfs.c | 17 ++++++++++++++++- > src/util/virsysfs.h | 6 ++++++ > 3 files changed, 23 insertions(+), 1 deletion(-) > > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms > index 9e61accda3fc..3965ef3f89c9 100644 > --- a/src/libvirt_private.syms > +++ b/src/libvirt_private.syms > @@ -2621,6 +2621,7 @@ virVasprintfInternal; > > > # util/virsysfs.h > +virSysfsDirOpen; > virSysfsGetCpuValueBitmap; > virSysfsGetCpuValueInt; > virSysfsGetCpuValueString; > diff --git a/src/util/virsysfs.c b/src/util/virsysfs.c > index c482e188a301..6686d8ddbfcb 100644 > --- a/src/util/virsysfs.c > +++ b/src/util/virsysfs.c > @@ -25,7 +25,6 @@ > #include "virsysfspriv.h" > > #include "viralloc.h" > -#include "virfile.h" > #include "virlog.h" > #include "virstring.h" > > @@ -120,6 +119,22 @@ virSysfsGetValueBitmap(const char *file, > * Per-CPU getters > */ > int > +virSysfsDirOpen(const char *file, > + DIR **dirp) > +{ > + char *path = NULL; > + > + if (virAsprintf(&path, "%s/%s", sysfs_system_path, file) < 0) > + return -1; > + > + if (!virFileIsDir(path)) > + return -2; > + > + return virDirOpen(dirp, path); > +} > + > > what if I need another util function like: virSysfsDirResctrlOpen(const char *file, DIR **dirp) do another copy and just modify path as: if (virAsprintf(&path, "%s/%s", sysfs_resctrl_path, file) < 0) is that okay for you to duplicated code like this? This is not so common a way to adding utils functions. If I need another `sysfs_system_path`, for /sys/fs/resctrl I need to add a new variable sysfs_resctrl_path, then do a copy of this function with some modification.