Re: [libvirt] [PATCH 1/4] qemu: Make Set*Mem commands hotplug only
On 02/15/2010 06:09 AM, Daniel P. Berrange wrote:
On Fri, Feb 12, 2010 at 10:32:14AM -0500, Cole Robinson wrote:
> SetMem and SetMaxMem are hotplug only APIs, any persistent config
> changes are supposed to go via XML definition. The original implementation
> of these calls were incorrect and had the nasty side effect of making
> a psuedo persistent change that would be lost after libvirtd restart
> (I didn't know any better).
>
> Fix these APIs to rightly reject non running domains.
ACK
Daniel
Thanks, pushed now. Will send a docs patch separately.
- Cole