Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages
On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote:
On Mon, Jan 22, 2018 at 12:05:19 +0000, Daniel Berrange wrote:
> This extends the update hook so that it enforces a requirement to have a
> Signed-off-by line in every commit message. This can be optionally
> turned off in individual repos by setting the "hooks.allowmissingsob"
> git config variable.
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
> update | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
NACK, I don't like signoffs and I don't really think they achieve
anything.
A signoff with no documented meaning attached by the project is fairly
weak, as you would have to argue there was some commonly accepted signifance
to it across the community. A signoff which is explicitly associated with a
statement of intent has benefit, hence why I also sent a patch to clarify
that the signoff asserts compliance with the DCO. Adding these signoffs has
little to no time burden on long term developers own work on a daily basis.
Just needs adding -s to "git commit" which quickly becomes engrained in
muscle memory such that you'll end up doing it for every project you find
yourself contributing to. Many of our "drive by" contributors already do
this as habit, we'll just need to remind those that forget periodically.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|