Re: [libvirt] [PATCH 1/4] Fix docs for PM event callbacks
On 09/06/2012 05:29 PM, Doug Goldstein wrote:
On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark
<jdenemar(a)redhat.com> wrote:
> PM{Suspend,Wakeup} event callbacks were designed with a reason parameter
> which could be used in the future. However, we do not transfer the
> reason over RPC and thus we can never use it in the future. Make it
> explicit in the docs.
> ---
> include/libvirt/libvirt.h.in | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Why can't we create a new RPC that _does_ pass reason, then when the
event fires, we call the appropriate RPC based on the capabilities of
the receiving end? That is, I don't think we are locked into never
being able to pass a useful reason.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 617 bytes)