Re: [libvirt] [PATCH] Make domain save work on root-squash NFS

FYI, I just verified that the restore failures I was seeing after applying this patch were actually happening *without* the patch as well, and are unrelated to domain save (it's a race condition in domain restore that needs to be dealt with separately), so this patch is okay to put in I verified I've been testing with an unmodified form of this patch, *EXCEPT* that I hadn't done make syntax-check on it (since I didn't really think that it was working code at the time ;-)), and there is one occurence of white-space at the end of a line. Should I resend with that change? Or do you want to just fix it up?

Also, notice that this patch saves the domain file with 0660 permission (umask will normally turn it into 0640) as we had thought that would be part of the way to allow restore from a root-squashed NFS server (just make sure that the reader had group read permissions). Now it seems we will be using the trick of running the restore code setuid instead, so the 0660 mode will no longer necessary. Should I revise this patch to create the file as 0600, or just do that as part of the upcoming domain restore patch?