Re: [libvirt] [PATCH 5/8] qemu: implement vsock hotplug
On Tue, Jun 05, 2018 at 07:40:25AM -0400, John Ferlan wrote:
[...]
>> + cleanup:
>> + if (ret < 0) {
>> + virErrorPreserveLast(&originalError);
>> + if (releaseaddr)
>> + qemuDomainReleaseDeviceAddress(vm, &vsock->info, NULL);
>> + virErrorRestore(&originalError);
>> + }
>> +
>> + virDomainVsockDefFree(vsock);
>
> This free is bogus - on success we consume the pointer and on failure
> the caller frees the device.
>
> I'll remove it before pushing.
>
yeah, right. Saw this too and wondered, started looking for it, then got
distracted... Looking again, now I wonder about qemuDomainAttachMemory
From qemuDomainAttachDeviceLive:
case VIR_DOMAIN_DEVICE_MEMORY:
/* note that qemuDomainAttachMemory always consumes dev->data.memory
* and dispatches DeviceAdded event on success */
ret = qemuDomainAttachMemory(driver, vm,
dev->data.memory);
dev->data.memory = NULL;
break;
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)