[libvirt] [PATCH v2 0/7] Support CHAP authentication for iscsi pool

https://bugzilla.redhat.com/show_bug.cgi?id=957294 Since Osier is out temporarily, I was asked to pick up this work since I initially reviewed the changes. Originally posted by Osier as: https://www.redhat.com/archives/libvir-list/2013-May/msg01879.html I reviewed the changes and had comments here: https://www.redhat.com/archives/libvir-list/2013-June/msg00286.html https://www.redhat.com/archives/libvir-list/2013-June/msg00288.html https://www.redhat.com/archives/libvir-list/2013-June/msg00290.html https://www.redhat.com/archives/libvir-list/2013-June/msg00294.html https://www.redhat.com/archives/libvir-list/2013-June/msg00298.html https://www.redhat.com/archives/libvir-list/2013-June/msg00303.html https://www.redhat.com/archives/libvir-list/2013-June/msg00301.html https://www.redhat.com/archives/libvir-list/2013-June/msg00302.html https://www.redhat.com/archives/libvir-list/2013-June/msg00304.html https://www.redhat.com/archives/libvir-list/2013-June/msg00305.html v2 changes * Adjust code/commit messages based on my comments and Osier's responses * Due to the issue noted in 7/11 from the original series regarding making the secret driver calls during the 'startPool()' path and not having a connection yet, I moved the calls to the 'findPoolSources()' entry since there is a connection provided then. Combined 6/11, 7/11, 8/11, & 9/11 into one commit. Since I complained about the lack of documentation that was also added to the formatstorage.html.in to describe the final level of changes. * My review of 9/11 missed that the two virSecret*() calls made above had to succeed prior to the direct reference of 'conn' in the secret driver secretGetValue() API. Still not convinced the code will work for the paths noted in my review, but either of the existing paths will return a NULL secret value thus there's no new regression. John Ferlan (2): storage: Support "username" for "chap" type "auth" storage: Introduce XMLs to use secret object for pool auth Osier Yang (5): storage: Refactor the rng schema for storage pool auth storage: Add a struct for auth secret storage: Output auth type before username storage: Support "chap" authentication for iscsi pool storage: Improve the pool auth type parsing and formatting docs/formatsecret.html.in | 10 +- docs/formatstorage.html.in | 31 +++- docs/schemas/storagepool.rng | 51 ++++--- src/conf/storage_conf.c | 170 ++++++++++++++------- src/conf/storage_conf.h | 28 +++- src/storage/storage_backend_iscsi.c | 113 +++++++++++++- src/storage/storage_backend_rbd.c | 13 +- .../storagepoolxml2xmlin/pool-iscsi-auth-login.xml | 17 +++ .../pool-iscsi-auth-secret.xml | 19 +++ .../pool-iscsi-auth-username.xml | 17 +++ tests/storagepoolxml2xmlin/pool-iscsi-auth.xml | 17 --- .../pool-iscsi-auth-login.xml | 20 +++ .../pool-iscsi-auth-secret.xml | 22 +++ .../pool-iscsi-auth-username.xml | 20 +++ tests/storagepoolxml2xmlout/pool-iscsi-auth.xml | 20 --- .../pool-iscsi-vendor-product.xml | 2 +- tests/storagepoolxml2xmlout/pool-rbd.xml | 2 +- tests/storagepoolxml2xmltest.c | 3 +- 18 files changed, 442 insertions(+), 133 deletions(-) create mode 100644 tests/storagepoolxml2xmlin/pool-iscsi-auth-login.xml create mode 100644 tests/storagepoolxml2xmlin/pool-iscsi-auth-secret.xml create mode 100644 tests/storagepoolxml2xmlin/pool-iscsi-auth-username.xml delete mode 100644 tests/storagepoolxml2xmlin/pool-iscsi-auth.xml create mode 100644 tests/storagepoolxml2xmlout/pool-iscsi-auth-login.xml create mode 100644 tests/storagepoolxml2xmlout/pool-iscsi-auth-secret.xml create mode 100644 tests/storagepoolxml2xmlout/pool-iscsi-auth-username.xml delete mode 100644 tests/storagepoolxml2xmlout/pool-iscsi-auth.xml -- 1.8.1.4