Re: [libvirt] [libvirt-php] bug in libvirt_domain_change_vcpus()
On Mon, Sep 09, 2013 at 06:51:54PM +0200, Michal Novotny wrote:
Hi Olivier,
this is not really a bug as it's intended. The
libvirt_domain_change_vcpus() is not the same as (yet unimplemented)
virDomainSetVcpus() API so it's not bug. I realize that naming could be
a little confusing so if you like, feel free to rename
libvirt_domain_change_vcpus() to libvirt_domain_xml_change_vcpus() as
this API should be used to change number of vCPUS in the domain XML
itself and implement libvirt_domain_set_vcpus() calling real
virDomainSetVcpus() API function.
That function is also buggy in that it will silently turn a transient
guest into a persistent guest, which is almost certainly not what a
caller would expect
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|