Eric Blake wrote:
...
> +
> +static int parse_socket(int cpu)
> +{
Several tools (such as ctag, or even more simply, 'git grep "^func"')
work better if all function implementations are listed with split lines,
such that the function name starts at the first column:
static int
parse_socket(int cpu)
{
Would it be worth a global cleanup patch that does this throughout
libvirt, rather than the current ad hoc mix in declaration styles?
IMHO, definitely worthwhile.