Re: [libvirt] PATCH: 3/5: Allow FD for stdout/err to be passed in

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > The contract for virExec() currently allows the caller to pass in a NULL > for stdout/err parameters in which case the child will be connected to > /dev/null, or they can pass in a pointer to an int, in which case the > child will be connected to a pair of pipes, and the read end of the pipe > is returned to the caller. > > The LXC driver will require a 3rd option - we want to pass in a existing > file handler connected to a logfile. So this patch extends the semantics > of these two parameters. If the stderr/out params are non-NULL, but are > initialized to -1, then a pipe will be allocated. If they are >= 0, then > they are assumed to be existing FDs to dup onto the child's stdout/err. > > This change neccessitated updating all existing callers of virExec to > make sure they initialize the parameters to -1 to maintain existing > behaviour. ACK No technical problems... so here are some stylistic suggestions