Re: [libvirt] [PATCH] Add actions to virDomainLifecycle enum

> + <p> > + on_crash supports these additional actions. > Should we add a <since>0.8.4</since> tag here?

> +++ b/src/conf/domain_conf.c > @@ -81,7 +81,9 @@ VIR_ENUM_IMPL(virDomainLifecycle, VIR_DOMAIN_LIFECYCLE_LAST, > "destroy", > "restart", > "rename-restart", > - "preserve") > + "preserve", > + "coredump-destroy", > + "coredump-restart") > Hmm. These two new values are only valid for on_crash, but I don't see any code that rejects them for on_reboot or on_poweroff. Do we need a separate enum here, or do we just need to add better checking to the remaining clients to detect enum values they can't support?