Re: [libvirt] [PATCH] Restore skipping of setting capacity

On 04/23/2014 07:28 AM, John Ferlan wrote: > Commit id 'ac9a0963' refactored out the 'withCapacity' for the > virStorageBackendUpdateVolInfo() API. See: Fortunately, we haven't released this regression of mine :) > > http://www.redhat.com/archives/libvir-list/2014-April/msg00043.html >

However, I'm still a bit worried that we are just attacking the symptoms, instead of addressing things correctly. It seems like we should be smarter in storage_backend_* to not override a capacity that was already set when probing the file metadata. There's a pretty telling comment in virStorageFileGetMetadataInternal: /* XXX we should consider moving virStorageBackendUpdateVolInfo * code into this method, for non-magic files */ where I think that being a bit smarter about tracing which pieces of information are gathered in which order, and then prioritizing them so that metadata information takes priority over stat() information, could avoid the need to pass an updateCapacity flag through quite so many layers of function calls. We may still go with your patch, but let's wait a day or two to see if I can come up with something more elegant...