Re: [libvirt PATCH 13/16] qemu: store logCtxt in domain private data
On Wed, Oct 06, 2021 at 09:15:19 +0200, Ján Tomko wrote:
We might need it later for device hotplug.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/qemu/qemu_domain.h | 11 +++++++----
src/qemu/qemu_process.c | 5 ++++-
2 files changed, 11 insertions(+), 5 deletions(-)
So from the code it looks like we will keep a connection to virtlogd
open for the lifetime of the VM rather than we do now for the startup of
the VM. The commit message doesn't justify or mention this and that is
IMO a substantial change which could have consequences.
Additionally there's no code whic would re-create the context on
libvirtd restart, so even the 'might need it later for device hotplug'
would not work properly.