On Mon, Jan 13, 2014 at 07:41:10AM -0500, Francesco Romani wrote:
Hi,
[snip]
> > virDomainGraphicsSpiceAgentFileTransferTypeFromString(enable))
> > <= 0) {
> > + virReportError(VIR_ERR_XML_ERROR,
>
> It turns out this one should be _CONFIG_UNSUPPORTED, see
>
https://www.redhat.com/archives/libvir-list/2014-January/msg00521.html .
> Sorry for giving you a
> wrong advice on this before.
No problem, it's a trivial fix to do. Updated patch coming soon.
> ACK from me if you squash this change in before pushing. This will have to
> wait after 1.2.1 release though.
Sorry, you mean the two patches should become one again?
No problem for me, I'll do what's fits best for the project.
I meant no need to resend a new version of the patch as long as you
amend the commit to have the updated error code.
Christophe