Re: [libvirt] [PATCH 02/10] Introduce qemuMonitorJSONFindLinkPath
On 06/04/2015 09:58 AM, Ján Tomko wrote:
When traversing through the QOM tree, we're looking for
a link to a device, e.g.:
link<virtio-balloon-pci>
Introduce a helper that will format the link name at the start,
instead of doing it every time while recursing through the tree.
---
src/qemu/qemu_monitor.c | 4 ++--
src/qemu/qemu_monitor_json.c | 55 ++++++++++++++++++++++++++++++--------------
src/qemu/qemu_monitor_json.h | 8 +++----
3 files changed, 44 insertions(+), 23 deletions(-)
Should we add any ATTRIBUTE_NONNULL() to the new API defs in the .h
file? For the 4 args? Like other external API's... I'm OK avoiding it
for patch 1 since patch 2 is the eventual API.
ACK 1 & 2
John