Re: [PATCH v2 06/17] qemu: Use virtio-scsi by default on RISC-V

On Thu, Feb 15, 2024 at 02:02:25PM +0100, Peter Krempa wrote: > On Wed, Feb 14, 2024 at 18:11:13 +0100, Andrea Bolognani wrote: > > Just like piix3-uhci for USB, the choice of lsilogic for SCSI > > was dictated entirely by that being the default for legacy x86 > > guests. Use virtio-scsi instead. > > > > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com&gt; > > --- > > src/qemu/qemu_domain.c | 4 +++- > > ...virt-default-models.riscv64-latest.abi-update.args | 5 +++-- > > ...-virt-default-models.riscv64-latest.abi-update.xml | 11 ++++++++--- > > .../riscv64-virt-default-models.riscv64-latest.args | 5 +++-- > > .../riscv64-virt-default-models.riscv64-latest.xml | 11 ++++++++--- > > 5 files changed, 25 insertions(+), 11 deletions(-) > > So this is a rather important change. You should note it at least in the > release news. Strongly agreed. I'll be sure to handle that. > It might be worth even add a note to the XML definition > documentation, or at least the qemu driver specific page. Not sure about this. We don't seem to explicitly document most of the existing defaults, so I wouldn't even know where a change in defaults could possibly fit in. I think I'd skip this part, if that's okay with you.