Re: [libvirt] [PATCH] libvirt-guests: wait for ntp service

Michal Privoznik wrote: > On 20.09.2014 01:36, Jim Fehlig wrote: >> Martin Kletzander wrote: >>> Unfortunately I'm not very familiar with systemd files, but my guess >>> is that After=ntp-wait.service means it should be started after the >>> time is synchronized if and only if the ntp-wait.service unit is >>> enabled, otherwise it doesn't require it. >> >> Yes, this is my understanding too. > > And so is mine. The only concern I have is that syncing time on cold > boot of the host may take ages. Yep, I have this concern too. So I dug a bit further and see that ntp-wait (a perl script) scrapes the output of `ntpq -c "rv 0`, waiting for leap_alarm to change to leap_none, leap_add_sec, or leap_del_sec. On my test system, this took ~16min on cold boot :-(. ntp-wait.service failed in the meantime, since it by default calls /usr/sbin/ntp-wait with options to only wait 10min. > But on the other hand, it's better to start domains later and with > correct time than start asap with inaccurate time. ACK then, Given the above observations, I'll wait to see if you change your mind.