Re: [libvirt] [test-API PATCH] Added screenshot test

On 04/04/2012 01:23 PM, Guannan Ren wrote: > On 04/04/2012 06:30 PM, Martin Kletzander wrote: >> On 04/04/2012 07:13 AM, Guannan Ren wrote: >>> --- >>> repos/domain/screenshot.py | 5 +++++ >>> 1 files changed, 5 insertions(+), 0 deletions(-) >>> >>> diff --git a/repos/domain/screenshot.py b/repos/domain/screenshot.py >>> index 9986cab..eeda2b5 100644 >>> --- a/repos/domain/screenshot.py >>> +++ b/repos/domain/screenshot.py >>> @@ -55,3 +55,8 @@ def screenshot(params): >>> conn.close() >>> >>> return ret >>> + >>> +def screenshot_clean(params): >>> + """clean testing environment""" >>> + filename = params['filename'] >>> + os.system('rm -f %s.*' % filename) >> The extension can be different every time, so we have to check that. I'd >> prefer something like this: >> >> diff --git a/repos/domain/screenshot.py b/repos/domain/screenshot.py >> index 9986cab..c620085 100644 >> --- a/repos/domain/screenshot.py >> +++ b/repos/domain/screenshot.py >> @@ -39,8 +39,8 @@ def screenshot(params): >> st = conn.newStream(0) >> mime = dom.screenshot(st, params['screen'], 0) >> >> - ext = mimetypes.guess_extension(mime) or '.ppm' >> - filename = params['filename'] + ext >> + params['ext'] = mimetypes.guess_extension(mime) or '.ppm' > > This modification on params couldn't be passed in > screenshot_clean() > The params to screenshot_clean() is the same as the > screenshot() which > is from testcase config file. > > Darn :( That's exactly why I wanted the parameter passing between tests :) What do you suggest? Should I save the extension into another file or do we have any other option?