Re: [libvirt] [PATCH 0/6] Couple of perf events APIs fixes
On Thu, Mar 31, 2016 at 07:28:55 +0200, Michal Privoznik wrote:
I really like to see these in before release and thus APIs get
written in the stone.
One note though regarding the last patch: while writing it I've
noticed couple of other getter APIs don't grab any job at all. I
think they should grab _QUERY job though. So maybe those will
need some fixing too.
I've more-or-less ACKed the series, but it would be great if you could
improve the documentation for the new APIs since it really doesn't tell
anybody what's happening there.
Additionally the docs for 'virDomainGetPerfEvents' states that @params
is filled by 'VIR_DOMAIN_PERF_*' macros, but in reality the macro has a
different prefix: VIR_PERF_PARAM_CMT
Thanks for cleaning up the mess though.
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)