Re: [libvirt] [PATCH] testutils: Explicitly name virTestCompare*() arguments

On Wed, 2019-02-20 at 07:33 -0500, John Ferlan wrote: > On 2/20/19 2:37 AM, Michal Privoznik wrote: >> On 2/19/19 9:19 PM, John Ferlan wrote: >>> Assuming extraction (sigh) of the VIR_AUTOFREE, >> >> While I'd definitely want this to be split into two patches if it was >> fixing something under src/, but this is under tests/ and therefore I >> did not bother. The reason for splitting a patch into smaller >> semanticaly divided patches is to help distro maintainers to ease >> backports. And reviewers, and people digging through history possibly years down the line. Whether the change is in src/, tests/ or whatever else shouldn't make a difference, it's all code and we routinely have to fix bugs both in the library and in the corresponding test suite. There is barely ever a reason *not* to split changes into smaller, independent units; having to write "at the same time" in the commit message should be your hint that you're doing it wrong ;)