Re: [PATCH 1/4] conf: add loader type 'none'
On Wed, Mar 22, 2023 at 10:40:33AM -0300, Daniel Henrique Barboza wrote:
On 3/22/23 10:02, Andrea Bolognani wrote:
> On Wed, Mar 22, 2023 at 09:32:21AM -0300, Daniel Henrique Barboza wrote:
> > VIR_DOMAIN_LOADER_TYPE_OTHER seems more appropriate to indicate that the
firmware
> > will be loaded not by QEMU, but other means (e.g. kernel).
>
> I'm not sure we really need a new loader type. Can't we just add
> '-bios none' unconditionally on RISC-V when a loader path or a kernel
> path have been provided, either manually or via autoselection?
Ubuntu for RISC-V works in libvirt without '-bios none' and with a -kernel path,
so
it's not like all RISC-V domains requires '-bios none'.
But does it *not* work with '-bios none'? When -kernel is used QEMU
should jump directly into the kernel anyway, so having a BIOS image
loaded shouldn't be necessary. I seem to recall that QEMU had
specific logic for this.
--
Andrea Bolognani / Red Hat / Virtualization