Re: [libvirt] [PATCH 1/4] HACKING: Drop from the git repository
On Mon, Jun 26, 2017 at 12:24:42PM +0200, Andrea Bolognani wrote:
Despite being a generated file, HACKING has been tracked in
the git repository along with actual source files. As far as
I'm aware, it's the only generated file for which that happens.
Times and times again, people[1] have committed changes to
the source file without refreshing the generated copy at the
same time.
The rationale for tracking the generated file is to help out
people who just cloned the git repository looking to contribue;
however, README-hacking already contains enough information to
get perspective contributors to a place where they can simply
look at docs/hacking.html instead.
I've no objection to this patch, but as a point for later work,
I think we should re-consider the approach for the hacking file.
In particular I think it is way too long now. I'd like to see
it cut back to the point where it basically just says how to
build & test the code from git and submit patches for review.
Move all the other content to separate pages on the website.
We already have alot of such "libvirt internals" content in
separate webpages and there's no good reason why much of the
hacking file needs special treatment.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|