Re: [libvirt] [PATCH] qemu: Always set migration capabilities

On 11/10/2014 04:41 PM, Jiri Denemark wrote: > We used to set migration capabilities only when a user asked for them in > flags. This is fine when migration succeeds since the QEMU process is > killed in the end but in case migration fails or if it's cancelled, some > capabilities may remain turned on with no way to turn them off. To fix > that, migration capabilities have to be turned on if requested but > explicitly turned off in case they were not requested but QEMU supports > them. > > https://bugzilla.redhat.com/show_bug.cgi?id=1160997 > Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt; > --- > src/qemu/qemu_migration.c | 42 +++++++++++++++++++++++++++++------------- > src/qemu/qemu_monitor.c | 5 +++-- > src/qemu/qemu_monitor.h | 3 ++- > src/qemu/qemu_monitor_json.c | 5 +++-- > src/qemu/qemu_monitor_json.h | 3 ++- > tests/qemumonitorjsontest.c | 3 ++- > 6 files changed, 41 insertions(+), 20 deletions(-) ACK Don't forget to update the bug link before pushing.