Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume
On 11/17/2011 08:04 AM, Dave Allan wrote:
After an offline conversation with Eric about why file type is a
good
proxy for a filesystem that is unsuitable for a snapshot, I'm in
agreement with this patch. The argument boils down to
1) block devices are really the only non-regular files that are useful
for backing guest block devices
The other non-regular files being directories, chardevs, symlinks,
fifos, and sockets.
2) the vast majority of block devices on modern systems live in
filesystems that are unsuitable for snapshots (e.g., devfs)
3) if a user has a use case that requires mknod'ing a block device in
a filesystem capable of storing snapshots, they can override the
libvirt check by supplying a filename which libvirt will honor.
so, ACK to the design.
I've gone ahead and pushed this patch.
>>> * src/conf/domain_conf.c (virDomainSnapshotAlignDisks):
Only
>>> generate names if backing file exists as regular file.
>>> Reported by MATSUDA Daiki.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)