Re: [libvirt] [PATCH] send 'container=libvirt' in env to container init

On 05/16/2011 09:14 AM, Serge Hallyn wrote: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html Environment variable names used by the utilities in the Shell and Utilities volume of POSIX.1-2008 consist solely of uppercase letters, digits, and the <underscore> ( '_' ) from the characters defined in Portable Character Set and do not begin with a digit. Other characters may be permitted by an implementation; applications shall tolerate the presence of such names. Uppercase and lowercase letters shall retain their unique identities and shall not be folded together. The name space of environment variable names containing lowercase letters is reserved for applications. Applications can define any environment variables with names from this name space without modifying the behavior of the standard utilities. That is, if your startup scripts make anything in the system, including /bin/sh, behave differently because it is in a container, then it's probably better to use an upper-case name, since /bin/sh should not behave differently regardless of what lower-case names are in the environment. But this is a borderline case - upstart is outside the realm of POSIX, and you can easily arrange for $container to be reset before any standard applications are ever invoked from within the container. Do you have a pointer to the liblxc code that's inspecting its environment? -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org